Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
🟡 Changes recommended
The backend-compatibility behavior lacks regression assertions in the existing unit tests.
4 open findings
What changed in this PR
Adds primary cache keys to restore-key lists for compatibility with third-party cache backends that only prefix-match restore keys.
Changes:
- Updates dependency, TRAP, and overlay cache restoration.
- Applies the behavior consistently across source call sites.
| File | Description |
|---|---|
src/trap-caching.ts |
Adds the preferred key to restore keys. |
src/dependency-caching.ts |
Adds the primary dependency key to restore keys. |
src/overlay/status.ts |
Adds the status key to restore keys. |
src/overlay/caching.ts |
Fixes overlay-base restoration on affected backends. |
lib/entry-points.js |
Excluded generated file; not reviewed. |
Files excluded by content exclusion policy (1)
- lib/entry-points.js
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| const primaryKey = await cacheKey(codeql, features, language, patterns); | ||
| const restoreKeys: string[] = [ | ||
| primaryKey, |
| [dbLocation], | ||
| cacheRestoreKeyPrefix, | ||
| undefined, | ||
| [cacheRestoreKeyPrefix], |
| const foundKey = await waitForResultWithTimeLimit( | ||
| MAX_CACHE_OPERATION_MS, | ||
| actionsCache.restoreCache([statusFile], cacheKey), | ||
| actionsCache.restoreCache([statusFile], cacheKey, [cacheKey]), |
| const found = await waitForResultWithTimeLimit( | ||
| MAX_CACHE_OPERATION_MS, | ||
| actionsCache.restoreCache([cacheDir], preferredKey, [ | ||
| preferredKey, |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4202 for context. Apparently some third-party systems don't use the primary cache key that's used for cache restores as a restore key if it's not also included separately as a restore key. This PR changes our
restoreCachecalls so that the primary restore key is also always included as a restore key. This should not make a difference on first-party systems.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
Third-party runner environments.
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
Merge / deployment checklist